Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Add foundation pages UI #39832

Merged
merged 19 commits into from
Oct 22, 2024

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented Oct 20, 2024

Proposed changes:

  • Adds a basic UI with save functionality for the foundation pages.
  • No validation, nothing. Pretty things will be added later. Code is also re-used so that will be fixed later as well.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Make sure you can add text to the lonely textarea and save that text.

@dilirity dilirity added [Status] In Progress [Plugin] Boost A feature to speed up the site and improve performance. labels Oct 20, 2024
@dilirity dilirity self-assigned this Oct 20, 2024
Copy link
Contributor

github-actions bot commented Oct 20, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Boost plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@dilirity dilirity requested a review from a team October 20, 2024 15:10
@dilirity dilirity marked this pull request as ready for review October 20, 2024 15:10
Copy link
Contributor

@donnchawp donnchawp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, except the regexp thing. Need to validate a URL, eventually.

It will be added at a later point.
@dilirity dilirity requested a review from haqadn October 22, 2024 14:35
@dilirity dilirity merged commit f56920b into add/foundation-pages Oct 22, 2024
47 checks passed
@dilirity dilirity deleted the update/boost/add-foundation-pages-ui branch October 22, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants